DroidFish: Fixed some lint warnings.

DroidFish/res/layout-land/editboard.xml

@@ -17,7 +17,6 @@
         android:orientation="vertical"
         android:paddingLeft="2dp" >
         <LinearLayout
-            xmlns:android="http://schemas.android.com/apk/res/android"
             android:id="@+id/first_title_line"
             android:layout_width="fill_parent"
             android:layout_height="wrap_content"
@@ -100,14 +99,12 @@
                 android:text="@string/cancel" />
         </LinearLayout>
         <LinearLayout
-            xmlns:android="http://schemas.android.com/apk/res/android"
             android:id="@+id/footer"
             android:layout_width="fill_parent"
             android:layout_height="match_parent"
             android:gravity="bottom"
             android:orientation="horizontal" >
             <LinearLayout
-                xmlns:android="http://schemas.android.com/apk/res/android"
                 android:id="@+id/second_title_line"
                 android:layout_width="fill_parent"
                 android:layout_height="wrap_content"

DroidFish/res/layout-land/main.xml

@@ -10,7 +10,6 @@
         android:layout_width="fill_parent"
         android:layout_height="fill_parent"/>
     <LinearLayout
-        xmlns:android="http://schemas.android.com/apk/res/android"
         android:layout_width="fill_parent"
         android:layout_height="fill_parent"
         android:layout_marginLeft="2dp"

DroidFish/res/layout/main_left_handed.xml

@@ -5,7 +5,6 @@
     android:layout_width="fill_parent"
     android:layout_height="fill_parent">
     <LinearLayout
-        xmlns:android="http://schemas.android.com/apk/res/android"
         android:orientation="vertical"
         android:layout_marginRight="2dp"
         android:layout_weight="1"

DroidFish/res/layout/title.xml

@@ -8,7 +8,6 @@
     android:orientation="vertical"
     android:tag="title" >
     <LinearLayout
-        xmlns:android="http://schemas.android.com/apk/res/android"
         android:id="@+id/first_title_line"
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
@@ -58,7 +57,6 @@
         </TextView>
     </LinearLayout>
     <LinearLayout
-        xmlns:android="http://schemas.android.com/apk/res/android"
         android:id="@+id/second_title_line"
         android:orientation="horizontal"
         android:layout_width="fill_parent"

DroidFish/res/values-de/strings.xml

@@ -229,7 +229,6 @@ wenn Sie es nicht aktiv nutzen.\
   <string name="option_draw">Remis anbieten/annehmen</string>
   <string name="option_select_book">Eröffnungsbuch auswählen</string>
   <string name="option_manage_engines">Schach-Engines verwalten</string>
-  <string name="option_select_engine">Schach-Engine auswählen</string>
   <string name="option_color_theme">Farbschema auswählen</string>
   <string name="option_about">Information/Hinweise</string>
   <string name="prefs_playing_options">Spieloptionen</string>
@@ -289,8 +288,6 @@ wenn Sie es nicht aktiv nutzen.\
   <string name="prefs_discardVariations_summary">Nicht-Hauptlinienzüge aus der Zugliste verwerfen</string>
   <string name="prefs_leftHanded_title">Linkshänder-Modus</string>
   <string name="prefs_leftHanded_summary">Steuerelemente auf der linken Seite im Querformat</string>
-  <string name="prefs_boardGestures_title">Spielfeld-Gesten</string>
-  <string name="prefs_boardGestures_summary">Langes Drücken auf das Spielfeld aktiviert das Hilfsmittel-Menü. Horizontales Wischen führt zur Rücknahme/ Wiederholung von Zügen. Vertikales Wischen springt zur vorherigen/ nächsten Variante.</string>
   <string name="prefs_squareSelectType_title">Feldauswahl</string>
   <string name="prefs_squareSelectType_summary">Festlegung der Auswahl von Feldern</string>
   <string name="prefs_fontSize_title">Schriftgröße</string>

DroidFish/res/values-es/strings.xml

@@ -225,7 +225,6 @@ Si está usted utilizando la batería, se recomienda que cambie los ajustes para
   <string name="option_draw">Ofrecer / Aceptar Tablas</string>
   <string name="option_select_book">Seleccionar Libro</string>
   <string name="option_manage_engines">Gestión de motores de ajedrez</string>
-  <string name="option_select_engine">Seleccionar Motor</string>
   <string name="option_color_theme">Ajustar rango de Colores</string>
   <string name="option_about"> Información / Ayuda</string>
   <string name="prefs_playing_options">Opciones de juego</string>
@@ -285,8 +284,6 @@ Si está usted utilizando la batería, se recomienda que cambie los ajustes para
   <string name="prefs_discardVariations_summary">Descartar jugadas de líneas secundarias de la lista de movimientos</string>
   <string name="prefs_leftHanded_title">Modo zurdo</string>
   <string name="prefs_leftHanded_summary">Controles en el lado izquierdo en modo horizontal</string>
-  <string name="prefs_boardGestures_title">Acciones sobre el tablero</string>
-  <string name="prefs_boardGestures_summary">Mantenga el tablero presionado para acceder al menú de herramientas. Deslice el dedo horizontalmente a derecha e izquierda para retroceder/avanzar jugadas. Deslízelo verticalmente para ir a la anterior/siguiente variante.</string>
   <string name="prefs_squareSelectType_title">Selección de casilla</string>
   <string name="prefs_squareSelectType_summary">Controla cómo seleccionar el remarcado de las casillas en el tablero</string>
   <string name="prefs_fontSize_title">Tamaño del Texto</string>

DroidFish/res/values-fr/strings.xml

@@ -224,7 +224,6 @@ préserver la batterie, ou de quitter <i>DroidFish</i> en utilisant la touche re
   <string name="option_draw">Proposer/Accepter la Nulle</string>
   <string name="option_select_book">Sélectionner le livre d\'ouverture</string>
   <string name="option_manage_engines">Gérer les modules d\'échecs</string>
-  <string name="option_select_engine">Sélectionner le module d\'analyse</string>
   <string name="option_color_theme">Définir le thème de couleurs</string>
   <string name="option_about">À propos/Aide</string>
   <string name="prefs_playing_options">Paramètres de jeu</string>
@@ -284,8 +283,6 @@ préserver la batterie, ou de quitter <i>DroidFish</i> en utilisant la touche re
   <string name="prefs_discardVariations_summary">Ignorer les coups secondaires de la liste de coups</string>
   <string name="prefs_leftHanded_title">Mode gaucher</string>
   <string name="prefs_leftHanded_summary">Boutons situés sur le côté gauche en mode paysage</string>
-  <string name="prefs_boardGestures_title">Gestes sur l\'échiquier</string>
-  <string name="prefs_boardGestures_summary">Faire un appui long pour accéder au menu d\'options. Glisser horizontalement pour aller aux coups suivants/précédents. Glisser verticalement pour aller à la variation suivante/précédente.</string>
   <string name="prefs_squareSelectType_title">Sélection de la case</string>
   <string name="prefs_squareSelectType_summary">Définir le comportement de la saisie des cases</string>
   <string name="prefs_fontSize_title">Taille du texte</string>

DroidFish/res/values-it/strings.xml

@@ -218,7 +218,6 @@
   <string name="option_draw">Chiedi/Offri/Accetta la patta</string>
   <string name="option_select_book">Seleziona Libro delle Aperture</string>
   <string name="option_manage_engines">Gestisci i motori scacchistici</string>
-  <string name="option_select_engine">Seleziona il motore scacchistico</string>
   <string name="option_color_theme">Imposta il Tema del Colore</string>
   <string name="option_about">Informazioni/Aiuto</string>
   <string name="prefs_playing_options">Opzioni di gioco</string>
@@ -278,8 +277,6 @@
   <string name="prefs_discardVariations_summary">Scarta dalla lista delle mosse quelle che non sono nella linea principale</string>
   <string name="prefs_leftHanded_title">Modalità Mancini</string>
   <string name="prefs_leftHanded_summary">Controlli sul lato sinistro in modalità paesaggio</string>
-  <string name="prefs_boardGestures_title">Gesti sulla scacchiera</string>
-  <string name="prefs_boardGestures_summary">Pressione lunga sulla scacchiera per il menu degli strumenti. Scorri in orizzontale per annullare/ripetere le mosse. Scorri verticalmente per passare alla precedente/successiva variante.</string>
   <string name="prefs_squareSelectType_title">Selezione della casella</string>
   <string name="prefs_squareSelectType_summary">Controlla come si comporta la selezione delle caselle sulla scacchiera</string>
   <string name="prefs_fontSize_title">Dimensione del testo</string>

DroidFish/res/values-nl/strings.xml

@@ -225,7 +225,6 @@ daadwerkelijk af te sluiten (gebruik hiervoor de return toets op uw telefoon).\<
   <string name="option_draw">Remise aanbieden/accepteren</string>
   <string name="option_select_book">Selecteer openingsboek</string>
   <string name="option_manage_engines">Schaak engines beheren</string>
-  <string name="option_select_engine">Selecteer engine</string>
   <string name="option_color_theme">Kleurenschema instellen</string>
   <string name="option_about">Over/Help</string>
   <string name="prefs_playing_options">Spel opties</string>
@@ -285,8 +284,6 @@ daadwerkelijk af te sluiten (gebruik hiervoor de return toets op uw telefoon).\<
   <string name="prefs_discardVariations_summary">Zetten die niet tot de stamvoortzetting behoren weglaten</string>
   <string name="prefs_leftHanded_title">Linkshandige mode</string>
   <string name="prefs_leftHanded_summary">Bedieningsknoppen aan de linkerkant in landscape</string>
-  <string name="prefs_boardGestures_title">Bord bewegingen</string>
-  <string name="prefs_boardGestures_summary">Lang aanraken voor tools menu. Swipe horizontaal voor zet terug/vooruit. Swipe verticaal voor vorige/vorige variant.</string>
   <string name="prefs_squareSelectType_title">Veldselectie</string>
   <string name="prefs_squareSelectType_summary">Instellen hoe velden geselecteerd worden</string>
   <string name="prefs_fontSize_title">Tekstgrootte</string>

DroidFish/res/values-pl/strings.xml

@@ -226,7 +226,6 @@ nie korzystasz aktywnie z programu.\</string>
   <string name="option_draw">Zaproponuj/przyjmij remis</string>
   <string name="option_select_book">Wybierz książkę otwarć</string>
   <string name="option_manage_engines">Zarządzaj silnikami szachowymi</string>
-  <string name="option_select_engine">Wybierz silnik szachowy</string>
   <string name="option_color_theme">Ustaw schemat kolorów</string>
   <string name="option_about">O programie/pomoc</string>
   <string name="prefs_playing_options">Opcje gry</string>
@@ -286,8 +285,6 @@ nie korzystasz aktywnie z programu.\</string>
   <string name="prefs_discardVariations_summary">Pomiń posunięcia spoza głównych linii na liście posunięć</string>
   <string name="prefs_leftHanded_title">Tryb leworęczny</string>
   <string name="prefs_leftHanded_summary">Elementy sterujące po lewej stronie dla orientacji poziomej</string>
-  <string name="prefs_boardGestures_title">Gesty na szachownicy</string>
-  <string name="prefs_boardGestures_summary">Długie przyciśnięcie na szachownicy otwiera menu podręczne. Poziome przeciągnięcia - posunięcie w przód/tył. Pionowe przeciągnięcia - przejście do poprzedniego/następnego wariantu.</string>
   <string name="prefs_squareSelectType_title">Wybór pola</string>
   <string name="prefs_squareSelectType_summary">Kontroluje sposób wyboru pól na szachownicy</string>
   <string name="prefs_fontSize_title">Rozmiar tekstu</string>

DroidFish/res/values-pt/strings.xml

@@ -226,7 +226,6 @@ não estiver usando o programa diretamente.\</string>
   <string name="option_draw">Pedir/Aceitar empate</string>
   <string name="option_select_book">Livro de aberturas</string>
   <string name="option_manage_engines">Softwares de Xadrez</string>
-  <string name="option_select_engine">Escolher o software de Xadrez</string>
   <string name="option_color_theme">Escolher cor do tema</string>
   <string name="option_about">Sobre/Ajuda</string>
   <string name="prefs_playing_options">Opções de jogo</string>
@@ -286,8 +285,6 @@ não estiver usando o programa diretamente.\</string>
   <string name="prefs_discardVariations_summary">Descartar da lista lances fora da linha principal</string>
   <string name="prefs_leftHanded_title">Modo canhoto</string>
   <string name="prefs_leftHanded_summary">Controles à esquerda no modo paisagem</string>
-  <string name="prefs_boardGestures_title">Gestos no tabuleiro</string>
-  <string name="prefs_boardGestures_summary">Pressione longamente o tabuleiro para ativar o menu. Deslize horizontalmente para fazer/desfazer lances. Deslize verticalmente para ir para a variante anterior/próxima.</string>
   <string name="prefs_squareSelectType_title">Seleção de casa</string>
   <string name="prefs_squareSelectType_summary">Definir como selecionar casas no tabuleiro</string>
   <string name="prefs_fontSize_title">Tamanho da fonte</string>

DroidFish/res/values-ru/strings.xml

@@ -217,7 +217,6 @@
   <string name="option_draw">Заявить/Предложить/Принять ничью</string>
   <string name="option_select_book">Выбрать открываемую книгу</string>
   <string name="option_manage_engines">Управление шахматными движками</string>
-  <string name="option_select_engine">Выбрать движок</string>
   <string name="option_color_theme">Установить цветную тему</string>
   <string name="option_about">Информация / Помощь</string>
   <string name="prefs_playing_options">Опции партии</string>
@@ -277,8 +276,6 @@
   <string name="prefs_discardVariations_summary">Отказаться от хода не главной линии из списка ходов</string>
   <string name="prefs_leftHanded_title">Левосторонний режим</string>
   <string name="prefs_leftHanded_summary">Контроль слева в ландшафтном режиме</string>
-  <string name="prefs_boardGestures_title">Жесты на доске</string>
-  <string name="prefs_boardGestures_summary">Долго нажмите на доске для вызова меню инструментов. Проведите горизонтально, чтобы отменить/повторить ход. Проведите вертикально, чтобы сделать предыдущее/следующее изменение хода.</string>
   <string name="prefs_squareSelectType_title">Выбор клеток</string>
   <string name="prefs_squareSelectType_summary">Управление выбираемыми клетками на шахматной доске</string>
   <string name="prefs_fontSize_title">Размер текста</string>

DroidFish/res/values/strings.xml

@@ -242,7 +242,6 @@ you are not actively using the program.\
     <string name="option_draw">Claim/Offer/Accept Draw</string>
     <string name="option_select_book">Select Opening Book</string>
     <string name="option_manage_engines">Manage Chess Engines</string>
-    <string name="option_select_engine">Select Chess Engine</string>
     <string name="option_color_theme">Set Color Theme</string>
     <string name="option_about">About / Help</string>
     <string name="prefs_playing_options">Playing Options</string>

DroidFish/src/net/margaritov/preference/colorpicker/ColorPickerView.java

@@ -16,6 +16,7 @@
 
 package net.margaritov.preference.colorpicker;
 
+import android.annotation.SuppressLint;
 import android.content.Context;
 import android.graphics.Canvas;
 import android.graphics.Color;
@@ -40,6 +41,7 @@ import android.view.View;
  * setAlphaSliderVisible(boolean) to true.
  * @author Daniel Nilsson
  */
+@SuppressLint("ClickableViewAccessibility")
 public class ColorPickerView extends View {
 
 	private final static int	PANEL_SAT_VAL = 0;

DroidFish/src/org/petero/droidfish/book/DroidBook.java

@@ -18,6 +18,7 @@
 
 package org.petero.droidfish.book;
 
+import android.annotation.SuppressLint;
 import java.security.SecureRandom;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -49,6 +50,7 @@ public final class DroidBook {
             return TextIO.moveToUCIString(move) + " (" + weight + ")";
         }
     }
+    @SuppressLint("TrulyRandom")
     private Random rndGen = new SecureRandom();
 
     private IOpeningBook externalBook = new NullBook();

DroidFish/src/org/petero/droidfish/book/InternalBook.java

@@ -32,8 +32,10 @@ import org.petero.droidfish.gamelogic.Position;
 import org.petero.droidfish.gamelogic.TextIO;
 import org.petero.droidfish.gamelogic.UndoInfo;
 
+import android.annotation.SuppressLint;
 import android.util.FloatMath;
 
+@SuppressLint("UseSparseArrays")
 final class InternalBook implements IOpeningBook {
     private static HashMap<Long, ArrayList<BookEntry>> bookMap;
     private static int numBookMoves = -1;